Added support for historical data #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vterron
reviewed
Dec 10, 2024
| last_update=datetime.datetime.fromtimestamp(data["x"] / 1000), | ||
| )) | ||
|
|
||
| return fear_greed_historical |
There was a problem hiding this comment.
Are the values in response["data"] guaranteed to be sorted by date?
Consider sorting them here to return the response is deterministic.
|
Please update the |
I'm still a git noob it seems, wasn't aware that subsequent commits get automatically included in pull request
The historical method raises error when no data is found Additionally, the data is sorted from distant to most recent in case the data source provides unsorted data
Tests for the correct number of entries. Tests the first and last 5 entries of the historical data to make sure dataset is sorted in the correct order. I chose not to cross check the entire dataset to prevent bloating. We can reasonable assume based on the first and last five entries that method works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now query historical fear and greed data from the can data source directly. The default range of data that is returned is 1 year.